Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 documentation Fixes ProjectConfig from ControllerManagerConfig in the component-con… #2778

Merged
merged 2 commits into from
Jul 8, 2022
Merged

📖 documentation Fixes ProjectConfig from ControllerManagerConfig in the component-con… #2778

merged 2 commits into from
Jul 8, 2022

Conversation

tomasfabian
Copy link
Contributor

@tomasfabian tomasfabian commented Jun 29, 2022 •
edited by camilamacedo86
Loading

Description

The aim of this PR is to fix the following issue: Kubebuilder project with a component config - could not decode file into runtime.Object

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 29, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @tomasfabian!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tomasfabian. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2022
@tomasfabian tomasfabian changed the title - 📖 (:book:): documentation Fixes ProjectConfig from ControllerManagerConfig in the component-con… - (:book:): documentation Fixes ProjectConfig from ControllerManagerConfig in the component-con… Jun 30, 2022
@tomasfabian tomasfabian changed the title - (:book:): documentation Fixes ProjectConfig from ControllerManagerConfig in the component-con… - 📖 documentation Fixes ProjectConfig from ControllerManagerConfig in the component-con… Jun 30, 2022
@camilamacedo86 camilamacedo86 mentioned this pull request Jun 30, 2022
Closed
2 tasks
@camilamacedo86
Copy link
Member

Closing this one based in the comment: #2778 (comment)

However, please feel free to open issues and or contribute with other PRs.

@camilamacedo86 camilamacedo86 reopened this Jul 8, 2022
camilamacedo86
camilamacedo86 reviewed Jul 8, 2022
View reviewed changes
...src/component-config-tutorial/testdata/project/config/manager/controller_manager_config.yaml
apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
kind: ControllerManagerConfig
apiVersion: config.tutorial.kubebuilder.io/v2
kind: ProjectConfig
health:
healthProbeBindAddress: :8081
metrics:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomasfabian I am re-open this one.
After re-check I see that you are right here.

The example code leads to a misunderstanding if, you create a CustomType you need to update the file to use it instead. Could you please just assign the CLA so we get this one merged?

/lgtm
/approved
/ok-to-test

Copy link
Contributor Author

@tomasfabian tomasfabian Jul 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @camilamacedo86, thank you very much for accepting this PR.
I tried to assign the CLA. Is it ok now?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2022
camilamacedo86
camilamacedo86 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🥇

@camilamacedo86 camilamacedo86 changed the title - 📖 documentation Fixes ProjectConfig from ControllerManagerConfig in the component-con… 📖 documentation Fixes ProjectConfig from ControllerManagerConfig in the component-con… Jul 8, 2022
@camilamacedo86
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tomasfabian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0a60a3a into kubernetes-sigs:master Jul 8, 2022
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomasfabian @k8s-ci-robot @camilamacedo86