🐛 (go/v3, go/v4-alpha): fix makefile targets do not re-install binaries when they are found in the project bin directory

[FotiadisM]

Description

Change the Makefile targets controller-gen and envtest no longer try to download the binary when they can be found in the project/bin directory.

Motivation

Closes: #2843

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: FotiadisM (c497ed4)

[k8s-ci-robot]

Welcome @FotiadisM!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @FotiadisM. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

Thank you for the contribution 🥇

Could you just please address the nits and assign the CLA so that we can move forward here?

[FotiadisM]

Just changed my commit to use test -s $(LOCALBIN)/<binary> everywhere and removed |

[camilamacedo86]

/ok-to-test

Great work 🥇
Thank you for the contribution and to raise that.

[camilamacedo86]

/hold

@FotiadisM , it is faling because you did not regenerated the testdata dir.
Could you please run make generate and squash the commits so that we can get this one merged?

[FotiadisM]

/retest

[camilamacedo86]

/hold cancel

[camilamacedo86]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, FotiadisM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ebaron]

Hi, I just came across this PR while fixing a similar issue in our operator's Makefile. I was wondering if these test commands should use the variables for each binary, such as: test -s $(CONTROLLER_GEN). If the user overrides the tool variable (e.g. CONTROLLER_GEN), then this test will not work.

[FotiadisM]

I think you are right, it should probably be changed to

$(CONTROLLER_GEN): $(LOCALBIN)
	test -s $@ || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@$(CONTROLLER_TOOLS_VERSION)