-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 "Application Support" whitespace for mac plugins #2863
🐛 "Application Support" whitespace for mac plugins #2863
Conversation
|
Hi @jakobmoellersap. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @jakobmoellersap! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rashmigottipati @everettraven could you give a hand on this one?
/ok-to-test |
/test pull-kubebuilder-e2e-k8s-1-19-16 |
Checked both failing tests and they seem to be timeout related, can I just rerun them? |
golanci-lint still failing with exit 137 Exit code 137 is triggered when a pod or a container within your Kubernetes environment exceeds the amount of memory that they’re assigned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Seems like the error with the golangci-lint is memory related. For some reason it is running out of memory. I wonder if there is a need to bump memory limits in the GitHub Action itself.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven, jakobmoellersap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@everettraven I checked your GH Actions and I think we cannot simply increase the memory limit through a setting as can be observed in https://github.com/golangci/golangci-lint-action#how-to-use, since it is a machine-limitation in the action. The only way I know to circuvment this is to adjust the GC as can be seen in https://golangci-lint.run/usage/performance/#memory-usage to increase Garbage Collection Cycles. This reduces memory footprint at the cost of heavily increased lint runtime (may not be favorable for us) What do you I think I can do here to make this PR go in @camilamacedo86 @everettraven ? Heavy Memory Usage is actually pretty common in golang-ci, I wonder how other projects go about it? |
@jakobmoellersap I think modifying that @camilamacedo86 WDYT? |
@jakobmoellersap and @everettraven, I think we need to try to upgrade the lint version to the latest. It seems a bug. |
@camilamacedo86 i can take a look at it. Seems to be failing on a couple other PRs that I have seen as well. I'll create an issue for it and assign myself. |
Blocked by #2878 |
/lgtm |
This mini-PR simply fixes the Plugins Root Directory for darwin hosts for external Plugins.
Without this change the Plugin Discovery will always look in a non-existing Library Directory, causing the Lookup to permanently fail. A suggestion here would be to introduce the "Lookup Plugins" command that was discussed previously in the Discussion around #2600 to also make this debuggable without having to change log messages or introducing a cli debug flag