🌱 migrate kubebuilder CLI tests to ginkgo/v2 (this pr does not change the scaffolds done by the tool)

[jakobmoellerdev]

This PR makes sure to migrate kubebuilder and the corresponding scaffolding to gingko/v2. Currently the entire test suite of kubebuilder itself is migrated, however there are 2 things missing:

• Scaffolding needs to be updated (see https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/golang/v3/scaffolds/internal/templates/controllers/controller_suitetest.go#L134) but its a breaking change and needs to go into v4-alpha scaffolding which does not yet exist
• gingko CLI is recommended as test execution tool (especially for parallel suites) and we would have to adjust Makefiles for that, I want to take this opportunity and ask what about our POV on this

[k8s-ci-robot]

Hi @jakobmoellersap. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

Just saw that there is a previous pull for this in #2522 that got closed. Also leaving this in draft until we have dedicated v4 scaffolding

[camilamacedo86]

/ok-to-test

[jakobmoellerdev]

I would suggest to even open up this PR normally (to upgrade kubebuilder and its test) and then a follow-up PR for the scaffolding. That would make it a bit easier to maintain / review / plan. WDYT @camilamacedo86 ?

[camilamacedo86]

Hi @jakobmoellersap that is fine, you can work on this as normal PR. No problem at all.

we can also:

/ok-to-test

/test-all

[jakobmoellerdev]

/retest

[jakobmoellerdev]

/test pull-kubebuilder-e2e-k8s-1-19-16

[jakobmoellerdev]

/cc @camilamacedo86

[camilamacedo86]

Hi @jakobmoellersap,

I understand that this PR just change the CLI tests and not the tests scaffolded by the tool.

You are right and migrating the scaffold is a breaking change, however, in this case, I think we will not have the choice because controller-runtime and k8s which are dependencies of this project introduced that, see: kubernetes-sigs/controller-runtime#1977. Therefore, to keep the compatibility and look for maintainability it seems that the best approach is in a follow up we also change the default scaffolds and add the warning (⚠️ ). In the changelog, release we can provide the info and steps to help out the users change it in their projects easily.

So, if you would like to work on the follow up please feel free.

Also, thank you for your terrific work and contribution to the project 🥇

For me it is all fine:

/approved

c/c @everettraven @varshaprasad96

[jakobmoellerdev]

I will pick up the ginkgo v2 scaffolding migration next

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, jakobmoellersap, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/lgtm

Receive 2 approvals