-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add options and guidance to provide solutions for other platforms and within multiple architecture support #2906
Conversation
/retest-required |
4351305
to
dd6a726
Compare
fd3d82d
to
89ed3b4
Compare
5cc2a19
to
867ffea
Compare
/hold cancel Since I get via msg the lgtm from folks as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/lgtm Just to make official feedback I gave verbally. |
@jaypoulz: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@jeffdyoung: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some nits for the doc, other than that everything else looks good to me!
b8e12f4
to
ba4b3e3
Compare
… for other platforms and within multiple architecture supportbuild image to multi-cluster support Co-authored-by: Bryce Palmer <everettraven@gmail.com>
ba4b3e3
to
efdb1ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nit, rest looks good! Thanks @camilamacedo86
/lgtm
To provide support on specific or multiple platforms, you must ensure that all images used in workloads are built to | ||
support the desired platforms. Note that may not be the same as the platform where you develop your solutions | ||
and use KubeBuilder, but instead the platform(s) where your solution should run and be distributed. | ||
It is recommended to build solutions that work on multiple platforms so that your project works | ||
on any Kubernetes cluster regardless of the underlying operating system and architecture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
To provide support on specific or multiple platforms, you must ensure that all images used in workloads are built to | |
support the desired platforms. Note that may not be the same as the platform where you develop your solutions | |
and use KubeBuilder, but instead the platform(s) where your solution should run and be distributed. | |
It is recommended to build solutions that work on multiple platforms so that your project works | |
on any Kubernetes cluster regardless of the underlying operating system and architecture. | |
To provide support on specific or multiple platforms, you must ensure that all images used in workloads are built to | |
support the desired platforms. Note that this may not be the same as the platform where you develop your solutions using KubeBuilder, but instead the platform(s) where your solution would run and will be distributed. | |
It is recommended to build solutions that work on multiple platforms so that your project works | |
on any Kubernetes cluster regardless of the underlying operating system and architecture. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, camilamacedo86, jaypoulz, Kavinjsir, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
(before this PR we have authors building solutions where the container will have the support for Linux/arm64 and the binary to run the manager was built with linux/amd64 because it was fixed )
Motivation
Closes: #2697
Closes: #2850
Local Test with new OPTIONAL target make docker-buildx:
Building the image:
Checking the manifest list: