Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump Kubernetes version (1.24.1 -> 1.25.0) #2907

Closed
wants to merge 1 commit into from
Closed

🌱 Bump Kubernetes version (1.24.1 -> 1.25.0) #2907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/.goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ builds:
- darwin_amd64
- darwin_arm64
env:
- KUBERNETES_VERSION=1.24.1
- KUBERNETES_VERSION=1.25.0
Copy link
Member

@camilamacedo86 camilamacedo86 Sep 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Thank you for the contribution 🥇

We need to update the whole project accordingly and not only the goreleaser file.
See: #2908

Would you like to start to help out by creating the envtools binaries for 1.25?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c/c @sbueringer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Thank sounds great @camilamacedo86.

Copy link
Member

@sbueringer sbueringer Sep 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 Thx, I overlooked the base branch of this PR.

Just out of curiosity. Does bumping the version on the tools-releases branch depend on kubebuilder itself on main being bumped before?

EDIT: Ah "Would you like to start to help out by creating the envtools binaries for 1.25?" that's actually bumping the tools-release branch, right? And it has to be done first

Copy link
Member

@camilamacedo86 camilamacedo86 Sep 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sbueringer,

EDIT: Ah "Would you like to start to help out by creating the envtools binaries for 1.25?" that's actually bumping the tools-release branch, right? And it has to be done first

We use the envtest in the scaffolds as well see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/Makefile#L5

But updating the goreleases would need to be done when we update the whole project.

- CGO_ENABLED=0

# Only binaries of the form "kubebuilder_${goos}_${goarch}" will be released.
Expand Down