Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 : (fix golint) - Remove deprecated io/ioutil and use os, io instead #2931

Merged

Conversation

manu12miskin
Copy link
Contributor

@manu12miskin manu12miskin commented Sep 11, 2022

Summary:

This PR fixes the following error by removing deprecated io/ioutil and using os, io instead.

pkg/cli/alpha/config-gen/cmd.go:22:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"

Description of change:

  • Update ioutil.ReadAll => io.ReadAll
  • Update ioutil.ReadFile => os.ReadFile
  • Update ioutil.WriteFile => os.WriteFile

Motivation:

Helps resolve #2928

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @manu12miskin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2022
@manu12miskin manu12miskin changed the title (:bug:) Remove deprecated io/ioutil and use os, io instead 🐛 Remove deprecated io/ioutil and use os, io instead Sep 11, 2022
@camilamacedo86
Copy link
Member

/ok-to-test
/approved

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2022
@camilamacedo86 camilamacedo86 changed the title 🐛 Remove deprecated io/ioutil and use os, io instead :🌱 : Remove deprecated io/ioutil and use os, io instead Sep 12, 2022
@camilamacedo86 camilamacedo86 changed the title :🌱 : Remove deprecated io/ioutil and use os, io instead 🌱 : (fix golint) - Remove deprecated io/ioutil and use os, io instead Sep 12, 2022
@camilamacedo86
Copy link
Member

Hi @manu12miskin,

Thank you for your contribution. 🥇

See that this change does not affect end-users.
The goal is to fix the golint replacing the deprecated code.

Therefore, we use the emojis and the titles to generate the changelog.
So, I hope that you do not mind but I update the title accordingly.
For a better understanding see the contribution guide.: https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#pr-process

@camilamacedo86
Copy link
Member

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
@camilamacedo86
Copy link
Member

/approved

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, manu12miskin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit b589941 into kubernetes-sigs:master Sep 12, 2022
@manu12miskin manu12miskin deleted the fix-io/ioutil-deprecated branch September 12, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint broke on master because of the usage of io/ioutil which is deprecated
3 participants