Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update controller-tools version (v0.9.2->v0.10.0) #2956

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Sep 21, 2022

Updates the go dependency sigs.k8s.io/controller-tools from v0.9.2- to v0.10.0

Part of #2908

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2022
@camilamacedo86
Copy link
Member

Hi @oscr,

Thank you for the PR. We need to update it in the scaffolds and not only in the CLI, see:

Also, we need to run make, generate and update the samples.

@oscr
Copy link
Contributor Author

oscr commented Sep 21, 2022

  • 0.9.2

Thank you @camilamacedo86! 🙏 That's why I didn't get any generate diff.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥇

But we need to sort out the legacy test. it might be related to go versions, see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/unit-tests-legacy.yml

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, oscr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@everettraven
Copy link
Contributor

Ah I see now that controller-tools will be updated as part of this PR. I was working on #2954 as part of updating the CLI go.mod to use k8s 1.25 dependencies and just pushed a controller-tools bump and a bump to the Go version in https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/unit-tests-legacy.yml

@everettraven
Copy link
Contributor

@oscr @camilamacedo86 I will work on fixing the legacy unit test action as part of PR #2954 and back out my controller-tools bump. Once #2954 is merged, then we should be good to merge this one.

@oscr
Copy link
Contributor Author

oscr commented Sep 22, 2022

@everettraven That's awesome! Thank you so much for that 🙏

@everettraven
Copy link
Contributor

@oscr #2954 is merged. This PR should just need a rebase.

@camilamacedo86
Copy link
Member

Hi @oscr, just bump with the master to get #2954 so that will pass and we can merge this one.

c/c @everettraven

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2022
@camilamacedo86 camilamacedo86 merged commit 4ccb436 into kubernetes-sigs:master Sep 23, 2022
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2022
@oscr oscr deleted the controller-tools branch September 23, 2022 07:15
@oscr oscr mentioned this pull request Sep 23, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants