-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Updated the docs with the export keyword to enable the webhook. #2967
📖 Updated the docs with the export keyword to enable the webhook. #2967
Conversation
Welcome @yashsingh74! |
Hi @yashsingh74. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@yashsingh74 The "PR Verifier / PR Desc" fails because it requires a longer pr description. Could you please add a little more description of your pr? /ok-to-test |
@yashsingh74 The PR Verifier is still failing due to a missing PR type indicator. If you take a look at the CONTRIBUTING.md file you can see that for docs PR it requires the title to be prefixed with the 📖 symbol. You can achieve this by writing |
Thank you @everettraven for your quick help. I will also look into the guide as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @camilamacedo86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for the PR!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, varshaprasad96, yashsingh74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updated the docs with the
export
keyword to enable the webhook.As the controller is failing because the webhook is not exported correctly.
So, the following changes are updated in the kubebuilder - https://book.kubebuilder.io/cronjob-tutorial/running.html#running-webhooks-locally so webhooks can be exported before the make run -
Fixes: #2837