Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Updated the docs with the export keyword to enable the webhook. #2967

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

yashsingh74
Copy link
Member

@yashsingh74 yashsingh74 commented Sep 24, 2022

Updated the docs with the export keyword to enable the webhook.

As the controller is failing because the webhook is not exported correctly.
So, the following changes are updated in the kubebuilder - https://book.kubebuilder.io/cronjob-tutorial/running.html#running-webhooks-locally so webhooks can be exported before the make run -

export ENABLE_WEBHOOKS=false
make run

Fixes: #2837

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yashsingh74!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @yashsingh74. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2022
@oscr
Copy link
Contributor

oscr commented Sep 24, 2022

@yashsingh74 The "PR Verifier / PR Desc" fails because it requires a longer pr description. Could you please add a little more description of your pr?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2022
@yashsingh74 yashsingh74 changed the title Update docs with export path to enable webhook Updates the docs with the export keyword to enable the webhook. Sep 25, 2022
@yashsingh74 yashsingh74 changed the title Updates the docs with the export keyword to enable the webhook. Updated the docs with the export keyword to enable the webhook. Sep 25, 2022
@everettraven
Copy link
Contributor

@yashsingh74 The PR Verifier is still failing due to a missing PR type indicator. If you take a look at the CONTRIBUTING.md file you can see that for docs PR it requires the title to be prefixed with the 📖 symbol. You can achieve this by writing :book: before the rest of your PR title.

@yashsingh74 yashsingh74 changed the title Updated the docs with the export keyword to enable the webhook. 📖 Updated the docs with the export keyword to enable the webhook. Sep 26, 2022
@yashsingh74
Copy link
Member Author

@yashsingh74 The PR Verifier is still failing due to a missing PR type indicator. If you take a look at the CONTRIBUTING.md file you can see that for docs PR it requires the title to be prefixed with the 📖 symbol. You can achieve this by writing :book: before the rest of your PR title.

Thank you @everettraven for your quick help. I will also look into the guide as well.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2022
@yashsingh74
Copy link
Member Author

/assign @camilamacedo86

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks for the PR!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, varshaprasad96, yashsingh74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit e5ced84 into kubernetes-sigs:master Sep 26, 2022
@yashsingh74 yashsingh74 deleted the webhook-update branch September 27, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running the tutorial locally fails due to webhook certs
6 participants