-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs: supplement plugin creation #3008
📖 docs: supplement plugin creation #3008
Conversation
7c260a1
to
0f4e27c
Compare
0f4e27c
to
4c32e18
Compare
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kavinjsir,
I am ok with the changes made. Are you still working on this one OR is it all done for us to review and get it merged?
4c32e18
to
ad75e8c
Compare
/unhold |
ad75e8c
to
e735bdf
Compare
Hi @camilamacedo86 , thx for reviewing! I'm sorry to be late and do not make the update quite match to our basic idea. If the current acceptable, I'm also good to get it merge for now and create a following PR as enhancement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with. :-)
Let's see if we can get help from others as well.
So, I will just approve.
e735bdf
to
25b8355
Compare
25b8355
to
637f85a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice docs! Thanks @Kavinjsir!
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add a section in
create-plugin
to provide references for users who create the plugin to scaffold on top of whatcreate api
brings.Motivation
Resolve: #2874