-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add kubebuilder FAQ section #3044
Conversation
Hi @astraw99. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@camilamacedo86 Updated, PTAL thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @astraw99,
Great work 🥇
Thank you for your contribution.
@camilamacedo86 Updated, PTAL thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is great 🥇
Thank you for the contribution
/approved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astraw99, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is only to add a new FAQ section on the docs with some questions/answers.
It seems fine to be get merged without a second review.
Anyway we can always do follow up PRs to improve this one.
/lgtm
@camilamacedo86 With this PR and #3050 merged, but the FAQ and git-repo/edit icons did not show in the website https://book.kubebuilder.io/introduction.html |
Hi @astraw99, The docs changes are made in the master branch and will only be in prod when we do the next release. You can check then out in the master branch. For further info see the contribution guide here: https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#how-to-contribute-to-docs |
Fixes #1318 #1723 #3016 #3028
Add a FAQ section in the KB docs, and include some of the representational reported issues.
Will update it continuously, to help more users.
Also add
git-repo
andgit-edit
icons on the top-right page.Tested with
mdbook serve
locally, works fine.