Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 remove the workaround steps from the release doc #3161

Merged
merged 1 commit into from
Jan 19, 2023
Merged

📖 remove the workaround steps from the release doc #3161

merged 1 commit into from
Jan 19, 2023

Conversation

camilamacedo86
Copy link
Member

Description

remove the workaround steps from the release doc.
these steps are from the legacy method, which is no longer used

@camilamacedo86
📖 remove the workaround steps from the release doc
43ebec9 
## Description

remove the workaround steps from the release doc.
these steps are from the legacy method, which is no longer used
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2023
Kavinjsir
Kavinjsir approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Quick question:
Is that because we are using Github Action where we won't face the case to release locally any more?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

Hi @Kavinjsir

Quick question:
Is that because we are using Github Action where we won't face the case to release locally any more?

Before we used Google Cloud to do the builds. So, this steps were to help out when we faced an issue with the old process.
Now, we are using github actions so that is no longer accurate.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2023
@camilamacedo86
Copy link
Member Author

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 36bc3c4 into master Jan 19, 2023
@camilamacedo86 camilamacedo86 deleted the camilamacedo86-update-release branch May 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Kavinjsir approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @Kavinjsir