-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Copyright year #3173
Update Copyright year #3173
Conversation
Update cronjob_types.go
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Sajiyah-Salat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Sajiyah-Salat. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one we need to do a fully updated.
That would mean run the generate scripts with the latest changes, then came back the code, then run make to ensure that is all ok,
See; #2510 for a better understanding
PS.Not an good first issue because you need to ensure that all is == and you just changed the scaffolded.
Thank you @camilamacedo86 even if this is not a good first issue. I would like to understand more about it and will try to change that. the pr link you provided is not enough to understand the whole matter. let me know if there are other good resources available or we can connect in your free time to discuss the issue. Thank you. |
@camilamacedo86 I agree that we may cover this topic under #2510 Manual update of the copyright year and have an additional commit in the version control history can be redundancy. |
@Sajiyah-Salat In case you have interest in contributing around this topic, would you like to walk through the context referred in #2510 ? |
After going through all comments I think I understand few things and whats going on and what needs to change. I ran make generate command after changing the copyright year. and the deepcopy file changes. The thing is if we change anything in code and run make generate. machine generate its own code. Right? In this case we can just add one command in contributing.md telling contributors to run make generate before pushing your code. |
Can I work on website and the code blocks given in cronjob tutorial. I will add some features and remove some bugs which I have gone through following the tutorial. @camilamacedo86 let me know your thoughts regarding that. |
|
Hi @Sajiyah-Salat,
Yes, you are free to contribute with all and more than welcome. However, this one is about update the Copyright year and I think we conveyed that the right way to update the samples in the docs is by re-generating them with the scripts as described in #2510. That is a manually process until we be able to provide a better solutions which is the end goal of the task: #2510 So, I think we can close this one. WDYT? c/c @Kavinjsir |
@camilamacedo86 I agree. We can explore this while go overing #2510 |
Closing this one. |
The new year has already begun. I have update all the file with copyright year.