Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Copyright year #3173

Closed

Conversation

Sajiyah-Salat
Copy link
Contributor

@Sajiyah-Salat Sajiyah-Salat commented Jan 18, 2023

The new year has already begun. I have update all the file with copyright year.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sajiyah-Salat
Once this PR has been reviewed and has the lgtm label, please assign pwittrock for approval by writing /assign @pwittrock in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Sajiyah-Salat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2023
@Sajiyah-Salat Sajiyah-Salat marked this pull request as draft January 18, 2023 15:42
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2023
@Sajiyah-Salat Sajiyah-Salat changed the title Update year Update Copyright year Jan 18, 2023
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one we need to do a fully updated.
That would mean run the generate scripts with the latest changes, then came back the code, then run make to ensure that is all ok,

See; #2510 for a better understanding

PS.Not an good first issue because you need to ensure that all is == and you just changed the scaffolded.

@Sajiyah-Salat
Copy link
Contributor Author

Thank you @camilamacedo86 even if this is not a good first issue. I would like to understand more about it and will try to change that. the pr link you provided is not enough to understand the whole matter. let me know if there are other good resources available or we can connect in your free time to discuss the issue. Thank you.

@Sajiyah-Salat Sajiyah-Salat marked this pull request as ready for review January 18, 2023 16:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
@Kavinjsir
Copy link
Contributor

@camilamacedo86 I agree that we may cover this topic under #2510
(If I'm understanding correctly)

Manual update of the copyright year and have an additional commit in the version control history can be redundancy.

@Kavinjsir
Copy link
Contributor

@Sajiyah-Salat In case you have interest in contributing around this topic, would you like to walk through the context referred in #2510 ?
There is also a proposed solution there that intends to automate the samples in a pragmatic pattern.

@Sajiyah-Salat
Copy link
Contributor Author

After going through all comments I think I understand few things and whats going on and what needs to change. I ran make generate command after changing the copyright year. and the deepcopy file changes. The thing is if we change anything in code and run make generate. machine generate its own code. Right? In this case we can just add one command in contributing.md telling contributors to run make generate before pushing your code.
Also my generate code file deecopy is not seen in changed files while my commit is visible why?

@Sajiyah-Salat
Copy link
Contributor Author

Can I work on website and the code blocks given in cronjob tutorial. I will add some features and remove some bugs which I have gone through following the tutorial. @camilamacedo86 let me know your thoughts regarding that.

@Kavinjsir
Copy link
Contributor

After going through all comments I think I understand few things and whats going on and what needs to change. I ran make generate command after changing the copyright year. and the deepcopy file changes. The thing is if we change anything in code and run make generate. machine generate its own code. Right? In this case we can just add one command in contributing.md telling contributors to run make generate before pushing your code. Also my generate code file deecopy is not seen in changed files while my commit is visible why?

@Sajiyah-Salat

  1. If you are not clear about what happens when executing make generate, you may check Makefile and walk through the corresponding files such as test/testdata/generate.sh.
  2. We have stated the usage of make generate in CONTRIBUTING.md. It will be very appreciated if you may read through the file before uploading a PR.

@camilamacedo86
Copy link
Member

Hi @Sajiyah-Salat,

Can I work on website and the code blocks given in cronjob tutorial. I will add some features and remove some bugs which I have gone through following the tutorial. @camilamacedo86 let me know your thoughts regarding that.

Yes, you are free to contribute with all and more than welcome.

However, this one is about update the Copyright year and I think we conveyed that the right way to update the samples in the docs is by re-generating them with the scripts as described in #2510.

That is a manually process until we be able to provide a better solutions which is the end goal of the task: #2510

So, I think we can close this one. WDYT?

c/c @Kavinjsir

@Kavinjsir
Copy link
Contributor

@camilamacedo86 I agree. We can explore this while go overing #2510

@camilamacedo86
Copy link
Member

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants