Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 [docs] : corrected layout of manually_migration_guide_gov3_to_gov4.md #3176

Merged
merged 2 commits into from
Jan 21, 2023
Merged

馃摉 [docs] : corrected layout of manually_migration_guide_gov3_to_gov4.md #3176

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
355901d
corrected layout
swastik959 Jan 20, 2023
9b69713
co_doc
swastik959 Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,19 +135,20 @@ Note that if your project has multiple groups (`multigroup:true`) then the above

The PROJECT tracks the paths of all APIs used in your project. Ensure that they now point to `api/...` as the following example:

Before update:
**Before update:**

group: crew
kind: Captain
path: sigs.k8s.io/kubebuilder/testdata/project-v4/apis/crew/v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this to show up as a code block in the docs, so I think we probably want this to look like:

**Before Update**:
```
  group: crew
  kind: Captain
  path: sigs.k8s.io/kubebuilder/testdata/project-v4/apis/crew/v1
```

```

After Update:

```
**After Update:**


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

**After Update**:
```
  group: crew
  kind: Captain
  path: sigs.k8s.io/kubebuilder/testdata/project-v4/api/crew/v1
```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@everettraven
thanks for the feedback
you can check it now

group: crew
kind: Captain
path: sigs.k8s.io/kubebuilder/testdata/project-v4/api/crew/v1
```


### Update kustomize manifests with the changes made so far

Expand Down