✨ (go/v3,go/v4-alpha): instead of call script to install kustomize download it first

[jberkhahn]

The security management software IBM runs flags this line as a vulnerability and kill -9's it whenever you try to execute it (by running make bundle-build or using any of the operator sdk commands that use that make task). As a result, IBMers currently can't make use of that functionality. This changes up the line a little to be more palatable to our security software.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jberkhahn / name: Jonathan Berkhahn (7779c40)

[jberkhahn]

/hold
Would like to bring this up for discussion before merging, anyways.

As for the CLA, did that change somehow? I thought the IBM github org was a signatory to the CLA and my membership is public.

[bradtopol]

/retest

[everettraven]

It seems like this would result in the experience for a user being unchanged but not being flagged by automated security alerts. I'm fine with this change going in.

Will wait to add any labels so the bot doesn't auto merge and allow for further discussion

[jberkhahn]

todo: backport this to v3

[camilamacedo86]

Hi @jberkhahn,

Could you please add in the description the alerts/the output that you are facing which motivates you push this PR?

todo: backport this to v3

You do not backport. You need to change the makefile template for the go/v3 plugin and run make generate to ensure that testdata is updated as well.

[jberkhahn]

The security management software IBM runs flags this line as a vulnerability and kill -9's it whenever you try to execute it (by running make bundle-build or using any of the operator sdk commands that use that make task). As a result, IBMers currently can't make use of that functionality. We discussed this a bit internally and at the operator sdk meeting, and we think this is the most light-weight solution. I was going to attend the next kubebuilder meeting and discuss this, but I guess I just missed one so it's not for 2 weeks?

[camilamacedo86]

Hi @jberkhahn,

Regards #3187 (comment). The meeting is biweekly. The next one will be on Feb 9. But we do not need to bring that to the meeting.

I was just interested to know what errors were faced.
Why downloading the shell (instead of executing it) can solve the problem?

Regarding the proposed change, I do not have any strong opinion about it. Could you please update the go/v3 plugin (same boilerplate) and make generate?

[jberkhahn]

Ok, updated this to include v3

[Kavinjsir]

For the sake of consistency, do we also need to update here:
https://github.com/kubernetes-sigs/kubebuilder/blob/v3.9.0/Makefile#L90

golangci-lint:
	@[ -f $(GOLANGCI_LINT) ] || { \
	set -e ;\
	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell dirname $(GOLANGCI_LINT)) v1.50.1 ;\
	}

[camilamacedo86]

Hi @Kavinjsir

Regards #3187 (review)

golangci-lint:
@[ -f $(GOLANGCI_LINT) ] || {
set -e ;
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell dirname $(GOLANGCI_LINT)) v1.50.1 ;
}

We do not need to update this one because it is ONLY used by those that contributes with Kubebuilder. therefore, it will not affected the end-users.

[camilamacedo86]

@jberkhahn I updated the title accordingly.
However, would very great we be able to have in the description of this PR a better info regards the error faced and why the change is required so that others can better understand its motivations by reading that. Could you please provide it?

[jberkhahn]

updated the description

[jberkhahn]

/hold cancel

[everettraven]

/lgtm

[varshaprasad96]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven, jberkhahn, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86,varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jberkhahn]

/retest