Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upgrade the k8s to 1.26.1 and controller-runtime to 0.14.2 #3197

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

yashsingh74
Copy link
Member

Upgrade the version and the respective dependencies

  • k8s version from 1.26.0 to 1.26.1
  • controller-runtime from 0.14.1 to 0.14.2

Fixes: #3195

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yashsingh74. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
@yashsingh74
Copy link
Member Author

cc: @varshaprasad96

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2023
@camilamacedo86
Copy link
Member

You probably need to ensure that your branch is rebase with master and run make generate to update the samples, Could you please to do that to sorted out the CI that is failing?

…from 0.14.1 to 0.14.2

Signed-off-by: Yash Singh <syash@vmware.com>
@yashsingh74
Copy link
Member Author

I did the rebase but it doesn't show git conflicts. Also, I ran the make generate and pushed the changes.

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-test
/test pull-kubebuilder-e2e-k8s-1-23-13
/test pull-kubebuilder-e2e-k8s-1-24-7

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2023
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @yashsingh74! Everything looks good. There is just one suggestion on bumping the controller-tools version since we haven't merged this PR yet and there is already a patch release with a bug fix in c-t (0.11.3).

@@ -34,7 +34,7 @@ import (

const (
// ControllerRuntimeVersion is the kubernetes-sigs/controller-runtime version to be used in the project
ControllerRuntimeVersion = "v0.14.1"
ControllerRuntimeVersion = "v0.14.2"
// ControllerToolsVersion is the kubernetes-sigs/controller-tools version to be used in the project
ControllerToolsVersion = "v0.11.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we haven't merged this PR yet, and controller-tools has a v0.11.3 release (https://github.com/kubernetes-sigs/controller-tools/blob/v0.11.3/go.mod#L16) that uses k8s 1.26.1, it would be nice to bump it here too. We can do it in a follow up as well, but would be helpful to track it with a comment or an issue.

Copy link
Member

@camilamacedo86 camilamacedo86 Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshaprasad96, I think we can do the bump in a follow up wdyt?
Shows that we also have a new controller-runtime version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge this!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, varshaprasad96, yashsingh74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshaprasad96
Copy link
Member

The APIDiff test is expected to fail. Once the controller-tools comment is addressed, I can override the test and merge it.

@camilamacedo86 camilamacedo86 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 6, 2023
@varshaprasad96
Copy link
Member

/override go-apidiff

@k8s-ci-robot
Copy link
Contributor

@varshaprasad96: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • go-apidiff

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • netlify/kubebuilder/deploy-preview
  • pull-kubebuilder-e2e-k8s-1-23-13
  • pull-kubebuilder-e2e-k8s-1-24-7
  • pull-kubebuilder-e2e-k8s-1-25-3
  • pull-kubebuilder-e2e-k8s-1-26-0
  • pull-kubebuilder-test
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override go-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varshaprasad96 varshaprasad96 merged commit 8c4ebfc into kubernetes-sigs:master Feb 6, 2023
@yashsingh74 yashsingh74 deleted the bump-k8s-1-26-1 branch February 7, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump latest patch releases for k8s, controller-runtime and controller-tools
4 participants