Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 design doc with proposal to re-scaffold projects from scratch #3221
📖 design doc with proposal to re-scaffold projects from scratch #3221
Changes from 2 commits
a9a9c6b
894ec87
e574f49
f226b4d
629a6e9
e5557d0
1166cdc
944b419
b5088fa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the first glance (for someone new) the
from
andto
flags seem to befrom
andto
plugins. Thoughts on making it:The two major changes I made are:
As an operator author I would still prefer to have a backup created by default in the current directory. If not I would not want to lose the current project. The user can have the option of not doing a back up through
--no-backup
flag. Thoughts on that?The main use case of this command is to re-generate the project with another plugin. If it is not provided, instead of using the same plugin available and creating a copy, can we instead error? If the user would like to create a project with same APIs and plugin as they already have, they can specify it explicitly in the
plugins
field.Thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @varshaprasad96,
We might able to have the backup in the same directory if we create the a new dir prefixed with
.
(example my-operator/.backup/my-operator). I think that is a good idea 👍Why would be required to inform? if not informed that we will use the value from the PROJECT file that we can found in the layout. That allows we scaffold the project for the same plugin but to get the minor changes. Is that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about we keep
from:
andto
? It seems very intuitive. Also, we could allow only inform the project path as well to do this operation. (In this case the backup would only have this file)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86
from
,to
seems generic - its confusing if its the directory from where input project will be taken and re-created or the plugin names which need to be converted. I'd still preferinput-dir
andoutput-dir
to be specific, but we can change it later during the implementation too.