Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Added the test-coverage for completion.go and version.go inside cli pkg #3233

Merged
merged 1 commit into from
May 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions pkg/cli/completion_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header needs to be fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copyright 2022 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package cli

import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)

var _ = Describe("Completion", func() {
var (
c *CLI
)

BeforeEach(func() {
c = &CLI{}
})

When("newBashCmd", func() {
It("Testing the BashCompletion", func() {
cmd := c.newBashCmd()
Expect(cmd).NotTo(BeNil())
Expect(cmd.Use).NotTo(Equal(""))
Expect(cmd.Use).To(ContainSubstring("bash"))
Expect(cmd.Short).NotTo(Equal(""))
Expect(cmd.Short).To(ContainSubstring("Load bash completions"))
Expect(cmd.Example).NotTo(Equal(""))
Expect(cmd.Example).To(ContainSubstring("# To load completion for this session"))
})
})

Context("newZshCmd", func() {
It("Testing the ZshCompletion", func() {
cmd := c.newZshCmd()
Expect(cmd).NotTo(BeNil())
Expect(cmd.Use).NotTo(Equal(""))
Expect(cmd.Use).To(ContainSubstring("zsh"))
Expect(cmd.Short).NotTo(Equal(""))
Expect(cmd.Short).To(ContainSubstring("Load zsh completions"))
Expect(cmd.Example).NotTo(Equal(""))
Expect(cmd.Example).To(ContainSubstring("# If shell completion is not already enabled in your environment"))
})
})

Context("newFishCmd", func() {
It("Testing the FishCompletion", func() {
cmd := c.newFishCmd()
Expect(cmd).NotTo(BeNil())
Expect(cmd.Use).NotTo(Equal(""))
Expect(cmd.Use).To(ContainSubstring("fish"))
Expect(cmd.Short).NotTo(Equal(""))
Expect(cmd.Short).To(ContainSubstring("Load fish completions"))
Expect(cmd.Example).NotTo(Equal(""))
Expect(cmd.Example).To(ContainSubstring("# To load completion for this session, execute:"))
})
})

Context("newPowerShellCmd", func() {
It("Testing the PowerShellCompletion", func() {
cmd := c.newPowerShellCmd()
Expect(cmd).NotTo(BeNil())
Expect(cmd.Use).NotTo(Equal(""))
Expect(cmd.Use).To(ContainSubstring("powershell"))
Expect(cmd.Short).NotTo(Equal(""))
Expect(cmd.Short).To(ContainSubstring("Load powershell completions"))
})

})
})
3 changes: 2 additions & 1 deletion pkg/cli/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
)

func (c CLI) newVersionCmd() *cobra.Command {
return &cobra.Command{
cmd := &cobra.Command{
Use: "version",
Short: fmt.Sprintf("Print the %s version", c.commandName),
Long: fmt.Sprintf("Print the %s version", c.commandName),
Expand All @@ -33,4 +33,5 @@ func (c CLI) newVersionCmd() *cobra.Command {
return nil
},
}
return cmd
}
47 changes: 47 additions & 0 deletions pkg/cli/version_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
/*
Copyright 2022 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package cli

import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)

var _ = Describe("Version", func() {
var (
c *CLI
)

BeforeEach(func() {
c = &CLI{}
})

Context("newVersionCmd", func() {
It("Test the version", func() {
cmd := c.newVersionCmd()
Expect(cmd).NotTo(BeNil())
Expect(cmd.Use).To(ContainSubstring("version"))
Expect(cmd.Use).NotTo(Equal(""))
Expect(cmd.Short).NotTo(Equal(""))
Expect(cmd.Short).To(ContainSubstring("Print the"))
Expect(cmd.Long).NotTo(Equal(""))
Expect(cmd.Long).To(ContainSubstring("Print the"))
Expect(cmd.Example).NotTo(Equal(""))
Expect(cmd.Example).To(ContainSubstring("version"))
})
})
})
yashsingh74 marked this conversation as resolved.
Show resolved Hide resolved
Loading