Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 fix typo in the design docs to scaffold projects #3255

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

Sajiyah-Salat
Copy link
Contributor

Hello, I was going through the proposal and its well written but I found this typo and tried to fix this. Aince this is just a two words change. I dont feel like opening a issue for that. if its mandatory I will do that. Thank you.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Sajiyah-Salat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, Sajiyah-Salat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2023
@jmrodri
Copy link
Contributor

jmrodri commented Mar 1, 2023

@Sajiyah-Salat you need to update the PR to include a PR type as outlined in the PR Process here https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#pr-process I believe in this case it might be ✨

@Sajiyah-Salat
Copy link
Contributor Author

Okay, I will do this shortly.

@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-25-3

@camilamacedo86
Copy link
Member

/retest-required

@camilamacedo86 camilamacedo86 changed the title Sajiyah typofix 📖 fix typo in the design docs to scaffold projects Mar 6, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-24-7

@k8s-ci-robot k8s-ci-robot merged commit c997ff3 into kubernetes-sigs:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants