🌱 : stop to generate all samples for go/v3 #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
camilamacedo86
added
lgtm
|
/test pull-kubebuilder-e2e-k8s-1-24-7 |
everettraven
approved these changes
Mar 15, 2023
| # [Deprecated] - Project version 3 (default) uses plugin go/v3 (default). | ||
| scaffold_test_project project-v3 | ||
|
|
||
| # [Currently, default CLI plugin] - [Next version, alpha] Project version v4-alpha | ||
| scaffold_test_project project-v4 --plugins="go/v4" | ||
| scaffold_test_project project-v4-multigroup --plugins="go/v4" | ||
| scaffold_test_project project-v4-declarative-v1 --plugins="go/v4,declarative" |
There was a problem hiding this comment.
Should we replicate the -with-deploy-image and -with-grafana samples for go/v4?
There was a problem hiding this comment.
Forgot to expand the file to see that it already does 🤦 - ignore this
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The go/v3 has been deprecated.
Therefore, we no longer need to generate the samples with all addons options for go/v3 and we can keep only project-v3 as a base so we are able to review and compare the scaffolds.
Motivation
Make easier to keep the project maintained