Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 update cronjob tutorial sample to use go/v4 #3281

Merged

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Mar 11, 2023

Description

update cronjob tutorial sample to use go/v4

Motivation

Ensure that docs are using go/v4 and no longer go/v3

Motivation: #3117

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2023
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-test

@camilamacedo86 camilamacedo86 force-pushed the update-cronjob-tutorial branch 2 times, most recently from 4e068b0 to e5d312e Compare March 11, 2023 15:30
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Mar 11, 2023
@Eileen-Yu
Copy link
Member

Eileen-Yu commented Mar 12, 2023

Looks great!

@k8s-ci-robot
Copy link
Contributor

@Eileen-Yu: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2023
@camilamacedo86
Copy link
Member Author

I am moving forward with this one to help out the goal of : #3231

@k8s-ci-robot k8s-ci-robot merged commit 1dc75e3 into kubernetes-sigs:master Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants