-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs: Improve PROJECT file documentation #3287
Conversation
|
Welcome @ashutosh887! |
Hi @ashutosh887. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@camilamacedo86 Let me know if any further improvements are needed in the PR |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about we merge this newly created paragraph with the above sentence? For instance:
The PROJECT file was introduced since Kubebuilder releases 3.0.0, where the Plugins design was implemented. When scaffolding an operator, the CLI will generate a
PROJECT
file in the project's root directory. It tracks all data used to perform scaffolds and stores information on resources and plugins in use. These data enable plugins to make more informed decisions during scaffolding, improving their usefulness.
@Kavinjsir It looks good to me |
Sounds good to me :) |
@@ -4,6 +4,8 @@ | |||
|
|||
The Project Config represents the configuration of a Kubebuilder project. All projects that are scaffolded with the CLI will generate the `PROJECT` file in the projects' root directory. | |||
|
|||
The PROJECT file was introduced since Kubebuilder [release 3.0.0](https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.0.0), where the Plugins design was implemented. When scaffolding an operator, the CLI will generate a PROJECT file in the project's root directory. It tracks all data used to perform scaffolds and stores information on resources and plugins in use. These data enable plugins to make more informed decisions during scaffolding, improving their usefulness ([see an example PROJECT file](https://github.com/kubernetes-sigs/kubebuilder/blob/6f1f8c43cfbf260c971037ff039cca86a0980006/testdata/project-v3-with-deploy-image/PROJECT#L2-L21)). | |||
|
|||
## Versioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we ensure that we have here the info shared in the following email of this thread? https://groups.google.com/g/kubebuilder/c/5c4_Xc3Fjx0/m/TERhvqaPBQAJ
Also, could we use alias for the docs so that is easier for we keep it maintained?
The links should be at the bottom of the doc
I added some suggestions above ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I've done the changes as you've recommended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ashutosh887 it still not done, see the following suggestions:
- (to make links using alias) https://github.com/kubernetes-sigs/kubebuilder/pull/3287/files#r1141269463
- (to add alias at the bottom) https://github.com/kubernetes-sigs/kubebuilder/pull/3287/files#r1141269536
Could you please ensure that all links are with alias and the alias are at the bottom?
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
@camilamacedo86 I've tried to resolve the changes using GitHub suggestion as per your advise. |
@varshaprasad96 I've done the suggested changes |
@camilamacedo86 @Kavinjsir @everettraven Can we have another lgtm? |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has my lgtm after apply the suggestions
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
New changes are detected. LGTM label has been removed. |
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Thanks @camilamacedo86 |
I moved forward with this one because I understand that has the lgtm from @varshaprasad96 and @Kavinjsir as well. |
Thanks @camilamacedo86 @varshaprasad96 @Kavinjsir ✨ |
Change Description:
I've updated the Overview section in the Kubebuilder Docs project-config
Motivation:
It had to be updated because the
PROJECT
file was introduced since Kubebuilder release 3.0.0, where the Plugins design was introduced but the overview section was not clear.Fixes: #3088