Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 (kustomize/v1, kustomize/v2): remove multi arch node affinity patch from auth proxy #3311

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

NikhilSharmaWe
Copy link
Member

Description

This PR removes the multi-arch node affinity from auth proxy patch in kustomize/v1 plugin, since scheduling affects on pod level, not the pod level and it is affecting both the kube-rbac-proxy-patch and manager container.

Motivation

Fixes: #3272

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2023
@@ -53,22 +53,6 @@ metadata:
spec:
template:
spec:
affinity:
Copy link
Member

@camilamacedo86 camilamacedo86 Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikhilSharmaWe, if we will remove then we need to remove the code from the kustomize v1 and v2 plugins.
Could you please change it in both?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2023
@camilamacedo86
Copy link
Member

Hi @NikhilSharmaWe,

It is missing run make generate to update all samples and docs. Could you please rebase with master and run make generate?

@NikhilSharmaWe
Copy link
Member Author

NikhilSharmaWe commented Apr 15, 2023

@camilamacedo86 Yes, that is what I was looking. The issue is running make generate-docs fails in this PR's branch but also in the current kubebuilder master branch with:
ERRO[0000] error Initializing the project: /tmp/kubebuilder/bin/kubebuilder init --domain tutorial.kubebuilder.io --repo tutorial.kubebuilder.io/project --license apache2 --owner The Kubernetes authors --plugins=go/v4 --component-config failed with error: (exit status 1) Error: failed to initialize project: unable to run pre-scaffold tasks of "base.go.kubebuilder.io/v4": target directory is not empty (only go.mod, go.sum, files and directories with the prefix ".", files with the suffix ".md" or capitalized files name are allowed); found existing file "bin"

Is this an issue with versioning or something? Since I was not getting this error few days back.

@camilamacedo86
Copy link
Member

Hi @NikhilSharmaWe,

I executed make generate, and I did not face any issues from the master branch.
Also, I cannot face any error by running make generate-docs

Can you rebase with master and check it out?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2023
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-25-3

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member

/hold

Up we publish the next release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2023
@camilamacedo86
Copy link
Member

/hold cancel

I am updating the title accordingly either so that we can properly generate the release notes.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2023
@camilamacedo86 camilamacedo86 changed the title 馃悰 kustomize/v1: remove multi arch node affinity patch from auth proxy 馃悰 (kustomize/v1, kustomize/v2): remove multi arch node affinity patch from auth proxy Apr 21, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-25-3

@k8s-ci-robot k8s-ci-robot merged commit ff3fa67 into kubernetes-sigs:master Apr 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-arch node affinity patch included in auth proxy patch?
3 participants