-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 (kustomize/v1, kustomize/v2): remove multi arch node affinity patch from auth proxy #3311
馃悰 (kustomize/v1, kustomize/v2): remove multi arch node affinity patch from auth proxy #3311
Conversation
@@ -53,22 +53,6 @@ metadata: | |||
spec: | |||
template: | |||
spec: | |||
affinity: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikhilSharmaWe, if we will remove then we need to remove the code from the kustomize v1 and v2 plugins.
Could you please change it in both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
fd09e02
to
c9bbcca
Compare
Hi @NikhilSharmaWe, It is missing run |
@camilamacedo86 Yes, that is what I was looking. The issue is running Is this an issue with versioning or something? Since I was not getting this error few days back. |
Hi @NikhilSharmaWe, I executed Can you rebase with master and check it out? |
c9bbcca
to
0fa5740
Compare
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
/test pull-kubebuilder-e2e-k8s-1-25-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, NikhilSharmaWe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Up we publish the next release |
/hold cancel I am updating the title accordingly either so that we can properly generate the release notes. |
/test pull-kubebuilder-e2e-k8s-1-25-3 |
Description
This PR removes the multi-arch node affinity from auth proxy patch in
kustomize/v1
plugin, since scheduling affects on pod level, not the pod level and it is affecting both thekube-rbac-proxy-patch
andmanager
container.Motivation
Fixes: #3272