Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 : Document update - Fix document spelling mistake #3324

Conversation

pratikmota
Copy link
Contributor

@pratikmota pratikmota commented Apr 10, 2023

Fixes #3323
Motivation:

  • Need to improve kubebuilder documentation for community
  • remove spelling mistake and typo errors ( book-v3 branch)

Changes:
1] 6.4. Testing your own plugins
https://book.kubebuilder.io/plugins/testing-plugins.html
Simiply --> Simply
dimenstion --> dimension
Cleanup environment --> Clean up the environment

2] 6.1.3.1. kustomize/v1
https://book.kubebuilder.io/plugins/kustomize-v1.html
laguage --> language

3] 6.1.3.2. kustomize/v2-alpha
https://book.kubebuilder.io/plugins/kustomize-v2-alpha.html
plataform -> platform

4] 4.2.1. go/v3 vs go/v4-alpha
https://book.kubebuilder.io/migration/v3vsv4.html
customise --> customize

5] 3. Tutorial: Component Config
https://book.kubebuilder.io/component-config-tutorial/tutorial.html
with the a component --> with the component

6] 3.1. Changing things up
https://book.kubebuilder.io/component-config-tutorial/api-changes.html
exising project --> existing project

7] 3.3.1. Adding a new Config Type
https://book.kubebuilder.io/component-config-tutorial/config-type.html
explicity --> explicitly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @pratikmota. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🥇

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pratikmota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2023
@camilamacedo86 camilamacedo86 merged commit 03c9b25 into kubernetes-sigs:book-v3 Apr 14, 2023
camilamacedo86 added a commit that referenced this pull request Apr 14, 2023
camilamacedo86 pushed a commit to camilamacedo86/kubebuilder that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants