Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (API and go/v4): Upgrade go version to 1.20 #3355

Merged
merged 1 commit into from
May 1, 2023
Merged

✨ (API and go/v4): Upgrade go version to 1.20 #3355

merged 1 commit into from
May 1, 2023

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Apr 22, 2023 •
edited
Loading

Description

Upgrade Kubebuilder API to use go 1.20 as go/v4 (default scaffold) to use go/v4.

Closes: #3207
Closes: #3193

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2023
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-test
/test pull-kubebuilder-e2e-k8s-1-26-0

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-test

varshaprasad96
varshaprasad96 approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86 Do we need to do this for go/v3 also (its deprecated, but do we need to make this change to support latest Go version?)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshaprasad96
Copy link
Member

/lgtm

@camilamacedo86 Do we need to do this for go/v3 also (its deprecated, but do we need to make this change to support latest Go version?)

Got my answer in #3354. Please ignore the question :)

@k8s-ci-robot k8s-ci-robot merged commit db68e38 into kubernetes-sigs:master May 1, 2023
15 checks passed
@nakamasato nakamasato mentioned this pull request Jul 27, 2023
Closed
@nakamasato nakamasato mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

Assignees

@varshaprasad96 varshaprasad96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @varshaprasad96