-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 added tests for version.go #3361
Conversation
Hi @khareyash05. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
pkg/cli/version_test.go
Outdated
It("prints the version number", func() { | ||
err := cmd.Execute() | ||
Expect(err).ToNot(HaveOccurred()) | ||
Expect(buf.String()).To(Equal("1.0.0\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes are detected. LGTM label has been removed. |
@camilamacedo86 Kindly review |
Hi @khareyash05, See that the test is still not working. Note that you can test it locally either:
We are more than happy to get this one merged when it be fixed. /approved cancel |
removed extralines updated tests Create version_test.go
bd66dd1
to
099a6bc
Compare
the test must be fixed so that we can get this one merged
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: khareyash05 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@khareyash05: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
added tests for
pkg/cli/version.go
Fixes #3211