Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (deployImage) improve the controller tests scaffolded #3364

Merged
merged 1 commit into from
Jun 14, 2023
Merged

✨ (deployImage) improve the controller tests scaffolded #3364

merged 1 commit into from
Jun 14, 2023

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Apr 23, 2023 •
edited
Loading

Description

This PR removes from the controller test implemented by the Deploy Image plugin.
Improves the before and after each test by applying the CR on it to ensure better practices since, for each reconciliation test, we ought to apply the resource. So, also remove the CR applied after the tests are executed.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2023
@camilamacedo86 camilamacedo86 changed the title 🐛 (deployImage) fix controller tests implemented by removing unecesary code implementation ✨ (deployImage) improve the controller tests scaffolded Apr 23, 2023
@camilamacedo86 camilamacedo86 marked this pull request as ready for review April 23, 2023 16:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2023
@camilamacedo86 camilamacedo86 force-pushed the fix-deploy-image-test branch 5 times, most recently from e097678 to 3af9cfa Compare April 23, 2023 18:24
@camilamacedo86
Copy link
Member Author

@varshaprasad96 thank you for the review, can we merge this one now?

@camilamacedo86
Copy link
Member Author

@varshaprasad96, @Kavinjsir , @rashansmith @everettraven

Could we move forward here? WDYT?

I am looking for review/lgtm for we get this one merged

Kavinjsir
Kavinjsir approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

We have an approval / lgtm so I think that is fine for we are able to move forward.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit d9c14df into kubernetes-sigs:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Kavinjsir approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@everettraven everettraven Awaiting requested review from everettraven

@pwittrock pwittrock Awaiting requested review from pwittrock

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilamacedo86 @k8s-ci-robot @Kavinjsir @varshaprasad96