-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Add to the PROJECT file the CLI tag version used to do the scaffold #3387
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
# More info: https://book.kubebuilder.io/reference/project-config.html | ||
componentConfig: true | ||
domain: tutorial.kubebuilder.io | ||
kubebuilderVersion: unknown | ||
layout: | ||
- go.kubebuilder.io/v4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think if we want to track this one we will need to have the CLI version used per plugin and scaffold. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, got it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should ONLY be applied to the Project Config v3. |
||
projectName: project | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,6 +93,19 @@ func (c *cfg) SetProjectName(string) error { | |
} | ||
} | ||
|
||
// GetCLIVersion implements config.Config | ||
func (c cfg) GetCLIVersion() string { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should not change the config/v2 it is deprecated and the changes should be addressed into the config/v3 |
||
return "" | ||
} | ||
|
||
// SetCLIVersion implements config.Config | ||
func (c *cfg) SetCLIVersion(string) error { | ||
return config.UnsupportedFieldError{ | ||
Version: Version, | ||
Field: "kubebuilder version", | ||
} | ||
} | ||
|
||
// GetPluginChain implements config.Config | ||
func (c cfg) GetPluginChain() []string { | ||
return []string{"go.kubebuilder.io/v2"} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please revert this changes that has no relation with the scope of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, I use this changes to finish this PR... because I move the 'version.go' to other places.
If I don't move, I can't import that value from 'main' package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hun, it does not seem to make sense. This target is used to build the binary, and making changes here does not allow you to import or not a code to be used. We should not perform those changes to address this one.