📖 doc: Fix multigroup migration guide for v4

[juanluisvaladas]

Fixes #3401 .
This is necessary because the paths of the warning were incorrect.

I added two separate instructions for both v3 and v4 as there were a few more differences besides the path.

[k8s-ci-robot]

Welcome @juanluisvaladas!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @juanluisvaladas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[varshaprasad96]

/ok-to-test

[juanluisvaladas]

Thanks for the review!
There were a few trailing whitespaces so I removed those and then I did a manual merge and squash.

[camilamacedo86]

Thank you a lot for your contribution. it is amazing, just a few nits.

Note that the steps are mainly the same. The diff is that go/v3 does not have the controllers dir under internal dir.

So, could we not explain it with go/v3 and create a note to let the users know if they are using go/v3, which is deprecated, the steps are mainly the same? However, beware that the layout from go/v3 to go/v4 and the controllers, in this case, are in the root dir and not under the internal directory.

[camilamacedo86]

IHMO, we need to prioritize explaining all using go/v4 (current layout) and then add a note to allow users using go/v3 still know what they should do in their case.

[juanluisvaladas]

So, could we not explain it with go/v3 and create a note to let the users know if they are using go/v3, which is deprecated, the steps are mainly the same? However, beware that the layout from go/v3 to go/v4 and the controllers, in this case, are in the root dir and not under the internal directory.

I don't think that's a good idea, when I was doing the migration I found the statements confusing (even if the path was right I still think it'd be difficult). I think it's better to have duplicate instructions as the other option makes instructions less clear.

I modified this to have go/v4 first and removed the white lines and if you don't find this convincing then I'll remove the Go/v3 section and add the note.

[camilamacedo86]

Just a few nits. Otherwise, it has my /lgtm

[juanluisvaladas]

Hi, all the issues are addressed, also squashed everything into one commit.

[juanluisvaladas]

Hi @camilamacedo86, I didn't know this stuff about the project layout go/v2, so I decided to do a couple more modifications.

I rewrote the two notes on top almost from scratch. Please pay extra attention to those two points.
I removed the instructions for go/v3 (which were for go/v2) entirely and just duplicated the step for the controllers.

The rest remains unaltered.

[juanluisvaladas]

Hi, sorry for the delay.

I amended the commit, here's the diff before the amend for easier review:

git diff
diff --git a/docs/book/src/migration/multi-group.md b/docs/book/src/migration/multi-group.md
index c6b861bf..f3e318b1 100644
--- a/docs/book/src/migration/multi-group.md
+++ b/docs/book/src/migration/multi-group.md
@@ -19,7 +19,7 @@ You can verify the version by looking at the PROJECT file. The currently default
 recommended version is go/v4.
 
 The layout go/v3 is **deprecated**, if you are using go/v3 it is recommended that you migrate to
-go/v4, however this documentation is still valid. [(More Info)][migration-guide].
+go/v4, however this documentation is still valid. [Migration from go/v3 to go/v4][migration-guide].
 
 This document is incompatible with go/v2. The documentation for go/v2 is still available in
 the [legacy documentation](https://book-v2.book.kubebuilder.io/migration/multi-group.html).
@@ -121,3 +121,4 @@ single-group projects).
 
 [multi-group-issue]: https://github.com/kubernetes-sigs/kubebuilder/issues/923 "Kubebuilder Issue #923"
 [cronjob-tutorial]: /cronjob-tutorial/cronjob-tutorial.md "Tutorial: Building CronJob"

There are no further changes.

[camilamacedo86]

I could just find some nits the rest shows fine for me.

[juanluisvaladas]

I believe this time everything is addressed :)
All the suggestions were commited and the last comment was also taken care of.

[camilamacedo86]

It shows greta for me

Thank you a lot for your contribution 🥇

[camilamacedo86]

/pull-kubebuilder-test

[camilamacedo86]

Hi @juanluisvaladas,

Could you please rebase with master and squash the commits? So that we can get this one merged?

[juanluisvaladas]

@camilamacedo86 done

[camilamacedo86]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, juanluisvaladas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment