-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Quote download URL in quickstart docs #3424
📖 Quote download URL in quickstart docs #3424
Conversation
Copying and pasting the `curl` line in the installation docs conflicts with zsh (or perhaps oh-my-zsh), which incorrectly escapes parentheses. ```sh curl -L -o kubebuilder https://go.kubebuilder.io/dl/latest/$(go env GOOS)/$(go env GOARCH) ``` becomes: ```sh curl -L -o kubebuilder https://go.kubebuilder.io/dl/latest/$\(go env GOOS)/$(go env GOARCH) ``` Which of course doesn't have the desired result and errors out. Double-quoting the URL should ensure the interpolated shell commands have the desired outcome. Tested on zsh and bash.
|
Welcome @tragiclifestories! |
Hi @tragiclifestories. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
lgtm
Thank you for the collab 🥇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tragiclifestories The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Copying and pasting the
curl
line in the installation docs conflicts with zsh (or perhaps ohmyzsh, and perhaps only on Mac), which incorrectly escapes parentheses.becomes:
Which of course doesn't have the desired result and errors out.
Double-quoting the URL should ensure the interpolated shell commands have the desired outcome. Tested on zsh and bash.