-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Make external plugin path configurable #3437
✨ Make external plugin path configurable #3437
Conversation
Hi @Eileen-Yu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b5c869f
to
06be130
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall really great work! My biggest request is to take another pass at the tests implementation and try to break them down into individual smaller tests
06be130
to
67eab5d
Compare
67eab5d
to
63eb717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
HI @Eileen-Yu, Can we cover a little more with the tests:
It decrease here: https://coveralls.io/builds/60550613/source?filename=pkg%2Fcli%2Foptions.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good and is a step in the right direction. What I would like to see is for the tests for the $XDGHOME and $HOME environment variables to be distinct tests (so no if ... else block to perform special test logic)
b798681
to
12e5df7
Compare
8f4d0f3
to
d68ad58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🥇
Just a nit:
Otherwise, /lgtm
Is KB_PLUGINS_PATH the best name for the env var?
What about EXTERNAL_PLUGINS_PATH
only?
I mean without kubebuilder since other projects can export Kubebuilder and use it as lib to create their own tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great - I just have some more comments on the tests
d68ad58
to
afb4963
Compare
Co-authored-by: Bryce Palmer <everettraven@gmail.com>
afb4963
to
235d1e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Great work @Eileen-Yu !
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific work 🥇
/approved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Eileen-Yu, everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
KB_PLUGINS_PATH
to define a customized path to store external plugins.Sample
Motivation
Make the external plugin path configurable so that users can easily manage their external plugins.