Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Good practices Doc page created #3451

Closed
wants to merge 4 commits into from
Closed

📖 Good practices Doc page created #3451

wants to merge 4 commits into from

Conversation

Sajiyah-Salat
Copy link
Contributor

Description
Adds new section within Good Practices information

Partial Fixes for #3203
This pr is a duplicate from #3267 pr as I have messed the squashing and rebasing part.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2023
@Sajiyah-Salat Sajiyah-Salat changed the title Doc page created, linked to summary 📖 Good practices Doc page created Jun 13, 2023
@Sajiyah-Salat
Copy link
Contributor Author

Sajiyah-Salat commented Jun 13, 2023 •
edited

Can we merge this now? I have tried squashing this two commits. but looks like as it is a conflict resolved commit it doesnt show in git rebase.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2023
camilamacedo86
camilamacedo86 reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sajiyah-Salat

It shows great for me. Could you please rebase the commits so that we can get this one merged?

camilamacedo86
camilamacedo86 previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows great for me.
Can you please squash the commits for we are able to get this one merged?
Also, can you ping this PR in the kubebuilder channel so that we can get a feedback from the community as well?

Otherwise,

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@camilamacedo86 camilamacedo86 added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 20, 2023
@camilamacedo86 camilamacedo86 dismissed their stale review June 21, 2023 10:48

Please, ensure that you ask for community reviews, rebase this PR so that we can move forward

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Sajiyah-Salat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@Sajiyah-Salat @wmuizelaar
Update docs/book/src/reference/good-practices.md
21a5281 
Co-authored-by: Wietse Muizelaar <wietse@wietsemuizelaar.nl>
@Sajiyah-Salat
Copy link
Contributor Author

with the help of this pr. I am learning rebase in real projects so I am trying new things. just give me time and I will do that soon.

@k8s-ci-robot
Copy link
Contributor

@Sajiyah-Salat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-e2e-k8s-1-25-3 21a5281 link true /test pull-kubebuilder-e2e-k8s-1-25-3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb left review comments

@wmuizelaar wmuizelaar wmuizelaar left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Sajiyah-Salat @k8s-ci-robot @erikgb @wmuizelaar @camilamacedo86