Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add API fields in alpha generate subcommand #3489

Merged
merged 1 commit into from
Jul 13, 2023
Merged

✨ Add API fields in alpha generate subcommand #3489

merged 1 commit into from
Jul 13, 2023

Conversation

yyy1000
Copy link
Member

@yyy1000 yyy1000 commented Jul 7, 2023

Description:

We didn't inspect the resources fields in the previous version.
Now we can add support for APIs.
It will check the GVK and also other flags.
(I think the e2e test case can cover more, such as create api without resource or without controller or both, but here I don't know how to check the fields in an efficient way so I skip them now.)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yyy1000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

camilamacedo86
camilamacedo86 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥇

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-27-1

Kavinjsir
Kavinjsir approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@yyy1000
Copy link
Member Author

yyy1000 commented Jul 8, 2023

/retest

@camilamacedo86
Copy link
Member

/retest-required

@yyy1000
feat: add support for create API
38b2e39 
fix: golang lint

fix: uppercase for Kind

fix:nit

fix: better name

fix: add resource flag

feat: only namespaced when flag set
@yyy1000
Copy link
Member Author

yyy1000 commented Jul 12, 2023

/retest

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-26-0

@yyy1000
Copy link
Member Author

yyy1000 commented Jul 12, 2023

/retest

2 similar comments
@yyy1000
Copy link
Member Author

yyy1000 commented Jul 13, 2023

/retest

@yyy1000
Copy link
Member Author

yyy1000 commented Jul 13, 2023

/retest

@yyy1000
Copy link
Member Author

yyy1000 commented Jul 13, 2023

:) Finally it passed all CIs. I think it's OK to merge this and I can go to 'webhook' step.

camilamacedo86
camilamacedo86 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir, yyy1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fc50728 into kubernetes-sigs:master Jul 13, 2023
9 checks passed
@yyy1000 yyy1000 deleted the create-api branch July 14, 2023 01:34
@yyy1000 yyy1000 mentioned this pull request Aug 29, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@Kavinjsir Kavinjsir Kavinjsir approved these changes

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yyy1000 @k8s-ci-robot @camilamacedo86 @Kavinjsir