Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Docs update quick-start.md use "kubectl -k apply" #3500

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

csantanapr
Copy link
Member

Fixes #3499

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2023
@csantanapr csantanapr changed the title Update quick-start.md use "kubectl -k apply" Docs update quick-start.md use "kubectl -k apply" Jul 18, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 18, 2023
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not merge this one,
See your error: error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false

You probably did not executed make manifests to properly generate the manifests.

@csantanapr
Copy link
Member Author

Hi @camilamacedo86

I ran make manifests

The problem is that with using -f in kubectl apply it will process the two files as kubernetes manifest files, the kustomization.yaml is not a kubernets manifest is a kustomize manifest and you need to use kubectl -k not kubectl -f

you if you want to use -f then you need to specify the file kubectl -f config/samples/webapp_v1_guestbook.yaml

ls -l config/samples/ 
total 8
-rw------- 1 vscode vscode 124 Jul 21 17:40 kustomization.yaml
-rw------- 1 vscode vscode 361 Jul 21 17:40 webapp_v1_guestbook.yaml

This PR should be merge to use be able to process the directory that has a kustomize file

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the error is with error: error validating "config/samples/kustomization.yaml":

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, csantanapr, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2023
@camilamacedo86 camilamacedo86 changed the title Docs update quick-start.md use "kubectl -k apply" 📖 Docs update quick-start.md use "kubectl -k apply" Jul 23, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-26-0

@k8s-ci-robot k8s-ci-robot merged commit a5b246f into kubernetes-sigs:master Jul 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quick start error deploying sample CR
4 participants