Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update destroy function #3508

Merged
merged 1 commit into from
Jul 31, 2023
Merged

🌱 Update destroy function #3508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/e2e/utils/test_context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,12 @@ func (t *TestContext) Tidy() error {
// Destroy is for cleaning up the docker images for testing
func (t *TestContext) Destroy() {
//nolint:gosec
cmd := exec.Command("docker", "rmi", "-f", t.ImageName)
if _, err := t.Run(cmd); err != nil {
warnError(err)
// if image name is not present or not provided skip execution of docker command
if t.ImageName != "" {
Sajiyah-Salat marked this conversation as resolved.
Show resolved Hide resolved
cmd := exec.Command("docker", "rmi", "-f", t.ImageName)
if _, err := t.Run(cmd); err != nil {
warnError(err)
Sajiyah-Salat marked this conversation as resolved.
Show resolved Hide resolved
}
Sajiyah-Salat marked this conversation as resolved.
Show resolved Hide resolved
}
if err := os.RemoveAll(t.Dir); err != nil {
warnError(err)
Expand Down
Loading