Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 : apply kustomize dir with correct flags #3510

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

Kavinjsir
Copy link
Contributor

Description

Use -k instead of -f when instructing users to call kubectl apply for config/samples.

The config/samples consists of kustomize manifests, and kubectl apply -k typically processes for a kustomization directory.

Motivation

This is a following up from #3499

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2023
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 26, 2023
@camilamacedo86 camilamacedo86 changed the title 🐛 : apply kustomize dir with correct flags 📖 : apply kustomize dir with correct flags Jul 26, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-26-0

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-27-1

@k8s-ci-robot k8s-ci-robot merged commit b020c34 into kubernetes-sigs:master Jul 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants