-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Ensure external plugin can scaffold files in new directories #3519
🐛 Ensure external plugin can scaffold files in new directories #3519
Conversation
c5ea4d5
to
08c43bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shows great for me
/hold Fo @everettraven give their review either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally this looks good - thanks @Eileen-Yu for the PR! I do have one nit:
08c43bc
to
7cdcfa3
Compare
/test pull-kubebuilder-e2e-k8s-1-27-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that is good to fly now that the recommendation from @everettraven is either attended.
/lgtm
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Eileen-Yu, everettraven, Kavinjsir, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubebuilder-e2e-k8s-1-26-0 |
Description:
Ensure the path specified in
PluginResponse.Universe
is created before the real scaffolding logic.Example:
For the Universe:
Create
/home/user/foo-test/some/dir
before scaffolding so as to avoid errors like:Motivation:
Aims to fix the corresponding issue #3518