Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱: drop unused scripting #3521

Conversation

Kavinjsir
Copy link
Contributor

Description

Drop generate_cronjob.sh and generate_multiversion.sh as they seem unused.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kavinjsir
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 3, 2023
@Kavinjsir Kavinjsir changed the title refactor: drop unused scripting 🌱: drop unused scripting Aug 3, 2023
@Kavinjsir
Copy link
Contributor Author

/retest

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kavinjsir,

Good catcher. However, for we drop the miltoversion one we need to create the hack code to either generate this one. See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/hack/docs/generate_samples.go#L34C25-L35C41

We are only generting the content for cronjob tutorial so far and because of it the issue : #2510 still open.

If you want to change this one to remove the generate_cronjob_sh only we can move forward.
Also, if you would like to work on to contribute to finish the task #2510 for we are able to them delete above please feel free.

@Kavinjsir
Copy link
Contributor Author

Hi @Kavinjsir,

Good catcher. However, for we drop the miltoversion one we need to create the hack code to either generate this one. See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/hack/docs/generate_samples.go#L34C25-L35C41

We are only generting the content for cronjob tutorial so far and because of it the issue : #2510 still open.

If you want to change this one to remove the generate_cronjob_sh only we can move forward. Also, if you would like to work on to contribute to finish the task #2510 for we are able to them delete above please feel free.

@camilamacedo86 I agree with your idea that completing #2510 can be a higher priority and we can handle the unnecessary files when going through that.
As for me, I am not quite confident at this moment for myself to finish the docs generation for the multi-version tutorial as it seems a big work, however, I will keep an eye and go through when there is a chance.

Closing this PR since it is covered by #2510

@Kavinjsir Kavinjsir closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants