-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 fix escaped html in markdown code segments #3541
📖 fix escaped html in markdown code segments #3541
Conversation
Hi @typeid. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rebase this PR with the latest changes merged in the master so that we can check the change via the preview ?
ba91ee2
to
1d9d477
Compare
@camilamacedo86 Ah indeed, forgot to rebase. Done and the deploy-preview works now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Issue #3534
markerdocs
as mdBook preprocessor to generate most of ourReferences
section (e.g. CRD Validation)html.EscapeString()
on the output of the preprocessor (see here)Basically, mdBook handles the content as raw strings (code block) thus quotation marks and other HTML escaped symbols are not escaped
This PR aims to fix this issue by not HTML escaping the markdown code segments contained in the text, leaving the behavior up to mdBook.
Fixes #3540