Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Build kubebuilder-tools for k8s 1.28.0 #3545

Merged

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2023
@sbueringer
Copy link
Member Author

/assign @camilamacedo86

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2023
Copy link

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@killianmuldoon
Copy link

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@sbueringer
Copy link
Member Author

@killianmuldoon hold for? (you don't have approver rights in this repo anyway :))

@killianmuldoon
Copy link

No need to hold - just didn't know what the approval flow is in this repo - and auto-wrote /approve 😅

@furkatgofurov7
Copy link
Member

/cc @varshaprasad96

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@varshaprasad96
Copy link
Member

@sbueringer @furkatgofurov7 is there a tight timeline you are looking at to get envtest binaries for 1.28? The build is usually triggered along with a KB release. Now that we have c-r and controller-tools updated, we should be able to get this in soon.

@killianmuldoon
Copy link

/hold cancel

(just undoing my previous hold)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@sbueringer
Copy link
Member Author

@sbueringer @furkatgofurov7 is there a tight timeline you are looking at to get envtest binaries for 1.28? The build is usually triggered along with a KB release. Now that we have c-r and controller-tools updated, we should be able to get this in soon.

From my side there is no rush.

@furkatgofurov7
Copy link
Member

@sbueringer @furkatgofurov7 is there a tight timeline you are looking at to get envtest binaries for 1.28? The build is usually triggered along with a KB release. Now that we have c-r and controller-tools updated, we should be able to get this in soon.

From my side there is no rush.

Same, just wanted to see if we can get more eyes on this, thanks for info @varshaprasad96

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/aproved

@camilamacedo86
Copy link
Member

/approved

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@camilamacedo86
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023
@camilamacedo86
Copy link
Member

/hold cancel

Yes, we can move forward within.
However, could you please also do a follow up PR to bump ETCD (See; https://github.com/kubernetes-sigs/kubebuilder/blob/tools-releases/build/thirdparty/linux/Dockerfile)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9e49062 into kubernetes-sigs:tools-releases Aug 24, 2023
2 checks passed
@sbueringer sbueringer deleted the pr-build-1.28 branch August 24, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants