🐛 (deployimage/v1-beta1): fix scaffold with multigroup and and add optional plugins to multigroup sample to validate changes #3560
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
camilamacedo86
added
the
lgtm
|
/test pull-kubebuilder-e2e-k8s-1-27-1 |
| @@ -189,28 +189,15 @@ func (s *apiScaffolder) scaffoldCreateAPIFromPlugins(isLegacyLayout bool) error | |||
| // which will have its own controller template which set the recorder so that we can use it | |||
| // in the reconciliation to create an event inside for the finalizer | |||
| func (s *apiScaffolder) updateMainByAddingEventRecorder(isGoV3 bool, defaultMainPath string) error { | |||
There was a problem hiding this comment.
Wondering if we can drop the parameter isGoV3 bool if it is no longer used?
There was a problem hiding this comment.
Yep good point.
I changed that
…al plugins to multigroup sample to validate changes
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
/test pull-kubebuilder-e2e-k8s-1-27-1 |
|
Could we move forward now? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
added
the
lgtm
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pull-kubebuilder-e2e-k8s-1-25-3 |
1 similar comment
|
/test pull-kubebuilder-e2e-k8s-1-25-3 |
Description
Add the fix for: #3558
Also, add call to grafana and deployimage into the multigroup sample so that we can either test this options with multigroup layout
Closes: #3558