✨ (Kustomize/v2, go/v4): upgrade controller-tools from 0.12.0 to 0.13.0 #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
Kavinjsir
force-pushed
the
bump-controller-tools
branch
from
3583fe6
to
500d475
Compare
There was a problem hiding this comment.
Hi @Kavinjsir
Yep that is great.
Thank you for the collaboration 🥇
Just few nits:
- missing run make generate
- the title of the PR needs to use the emoj
:sparkles:so that it will be used to generate teh release notes. Also, would be good we do something like ":sparkles: (Kustomize/v2, go/v4): upgrade controller-tools from 0.12.0 to 0.13.0" (this one I updated. I hope that you do not mind)
camilamacedo86
changed the title
k8s-ci-robot
added
the
approved
|
@Kavinjsir please see that we need to fix the commit message |
camilamacedo86
removed
the
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
Kavinjsir
force-pushed
the
bump-controller-tools
branch
from
500d475
to
411a448
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Hey @camilamacedo86 , sorry I just saw your reviews. Thx for helping me with fixing a number errors in the PR!! For now, it looks two issues I'm not quite sure:
|
|
HI @Kavinjsir,
It seems that in the script to generate the docs it is missing we call |
Kavinjsir
force-pushed
the
bump-controller-tools
branch
from
411a448
to
aa72657
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
|
/test pull-kubebuilder-e2e-k8s-1-25-3 |
camilamacedo86
approved these changes
Aug 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
merged commit 4d1e3c5
into
kubernetes-sigs:master
15 of 17 checks passed
yyy1000
pushed a commit
to yyy1000/kubebuilder
that referenced
this pull request
Aug 27, 2023
….0 (kubernetes-sigs#3561) (go/v4): Upgrade controller-tools from 0.12.0 to v0.13.0
yyy1000
added a commit
to yyy1000/kubebuilder
that referenced
this pull request
Aug 27, 2023
feat: get data feat: add change feat: remove log feat: add e2e test build(deps): bump golang.org/x/tools from 0.11.0 to 0.12.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.11.0...v0.12.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> chore(docs): change folder pkg to internal/controller in the migration guide fix: ensure external plugin can scaffold files in new dirs :seedling: Image name edge cases covered (kubernetes-sigs#3514) imagename edge case cover :seedling: logs info updated (kubernetes-sigs#3512) logs info updated :bug: fix doc preview 🐛: sync kb binary from source code for docs (kubernetes-sigs#3520) fix: sync kb binary from source code for docs :bug: fix typos in scaffolded makefiles :book: fix escaped html in markdown code segments :bug: (go/v4) fix makefile target to build images ensuring its single responsability refactor: externalize cfg :bug: (deployimage): fix e2e tests which are using go/v3 which is deprecated. Ensure that we are using the go/v4 ensure that we call go tidy when we generate sample docs :sparkles: (Kustomize/v2, go/v4): upgrade controller-tools from 0.12.0 to 0.13.0 (kubernetes-sigs#3561) (go/v4): Upgrade controller-tools from 0.12.0 to v0.13.0 :sparkles: improve logs from alpha command generate :bug: (deployimage/v1-beta1): fix scaffold with multigroup and add optional plugins to multigroup sample to validate changes :bug: change deprecated warning to yellow feat: remove quota fix: add space fix: change kind Update test/e2e/alphagenerate/generate_test.go Co-authored-by: Tony (TianYi) <kavinjsir@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump controller-tools to v0.13.0
Motivation
Partially resolve #3549 to support Kubernetes v1.28.0