🐛 (go/v4): Start to check ENABLE_WEBHOOKS envvar into main.go to fix issue when webhooks are used

[lowang-bh]

Fixes #3559

describe: fix issue that webhook generated code in cmd/main.go ignored checking the env ENABLE_WEBHOOKS

Test result :

➜  guestbook git:(dev) ✗ export ENABLE_WEBHOOKS=false; make run
test -s /Users/wlh/go/src/github.com/lowang-bh/demo/guestbook/bin/controller-gen && /Users/wlh/go/src/github.com/lowang-bh/demo/guestbook/bin/controller-gen --version | grep -q v0.13.0 || \
	GOBIN=/Users/wlh/go/src/github.com/lowang-bh/demo/guestbook/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.13.0
/Users/wlh/go/src/github.com/lowang-bh/demo/guestbook/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/Users/wlh/go/src/github.com/lowang-bh/demo/guestbook/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
go run ./cmd/main.go
2023-09-02T18:47:24+08:00	INFO	setup	starting manager
2023-09-02T18:47:24+08:00	INFO	starting server	{"kind": "health probe", "addr": "[::]:8081"}
2023-09-02T18:47:24+08:00	INFO	controller-runtime.metrics	Starting metrics server
2023-09-02T18:47:24+08:00	INFO	controller-runtime.metrics	Serving metrics server	{"bindAddress": ":8080", "secure": false}
2023-09-02T18:47:24+08:00	INFO	Starting EventSource	{"controller": "guestbook", "controllerGroup": "webapp.my.domain", "controllerKind": "Guestbook", "source": "kind source: *v1.Guestbook"}
2023-09-02T18:47:24+08:00	INFO	Starting Controller	{"controller": "guestbook", "controllerGroup": "webapp.my.domain", "controllerKind": "Guestbook"}
2023-09-02T18:47:24+08:00	INFO	Starting workers	{"controller": "guestbook", "controllerGroup": "webapp.my.domain", "controllerKind": "Guestbook", "worker count": 1}

[k8s-ci-robot]

Hi @lowang-bh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lowang-bh]

Test finished successfully

[camilamacedo86]

Thank you for your contribution 🥇

Following some nits

• The plugins go/v2 and go/v3 are deprecated so changes should not be performed on them.
• After change the scaffold you need to run make generate so that all samples under testdata and docs will be properly updated. Could you please to do it?

[lowang-bh]

• After change the scaffold you need to run make generate

Done.

[camilamacedo86]

@lowang-bh,

Thank you.
Could you please squash the commits?
We need to have always just one commit to get merged per PR

PS.: I also updated title for we have a better info when we generate the release notes. I hope that you do not mind.

/ok-to-test

[lowang-bh]

Could you please squash the commits?

Done.

I also updated title for we have a better info when we generate the release notes. I hope that you do not mind

Thanks.

[camilamacedo86]

/lgtm
/approved

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

@lowang-bh

You need to run make generate =, see : https://github.com/kubernetes-sigs/kubebuilder/actions/runs/6063945828/job/16452451257?pr=3578#step:6:47

/hold

[camilamacedo86]

/hold cancel
/approved cancel

[lowang-bh]

Yes, I am looking into this issue. It always insert two pices of same code.

[lowang-bh]

/test pull-kubebuilder-e2e-k8s-1-27-1
/test pull-kubebuilder-e2e-k8s-1-25-3
/test pull-kubebuilder-e2e-k8s-1-26-0

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-25-3

[camilamacedo86]

/lgtm

[camilamacedo86]

The API fails because the change in the doc see:

sigs.k8s.io/kubebuilder/v3/hack/docs/internal/cronjob-tutorial
Incompatible changes:

• MainEnableWebhook: value changed from "\n\n\t/\n\t\tWe'''ll also set up webhooks for our type, which we'''ll t... to "\n\n\t/\n\t\tWe'''ll also set up webhooks for our type, which we'''ll t...'

• GOAPIDIFF_RC=1

Therefore, it is not a genuine breakchange.
So, we can move forward with this one.