-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs(cert-manager): Change ownership links #3610
📖 docs(cert-manager): Change ownership links #3610
Conversation
|
Welcome @jesse-c! |
Hi @jesse-c. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jesse-c,
That is great. Could you please just sign the CLA so that we can move forward with this one? See: #3610 (comment)
/lgtm
/ok-to-test
cert-manager became a CNCF project in 2022 [1]. The existing links to cert-manager, with Jetstack ownership, redirect to the new ownership. The updated links have been verified to be working. There was one file that had EOL whitespace formatting corrected. [1] https://www.cncf.io/blog/2022/10/19/cert-manager-becomes-a-cncf-incubating-project/
Thank you, @camilamacedo86, for the quick turn around! I've just finished the CLA process and the check is passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
@camilamacedo86: I can't see why the extracting ( Is this a known flaky action? Any suggestions on determining the cause of this failure? Thank you! 🙏🏻 [1] https://github.com/kubernetes-sigs/kubebuilder/pull/3606/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, jesse-c The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Moving forward with this one. |
67c798a
into
kubernetes-sigs:master
Thank you @camilamacedo86 for working through this with me! |
📖 docs(cert-manager): Change ownership links (kubernetes-sigs#3610)
cert-manager became a CNCF project in 2022 [1]. The existing links to cert-manager, with Jetstack ownership, redirect to the new ownership.
The updated links have been verified to be working.
There was one file that had EOL whitespace formatting corrected.
FIXES #3607
[1] https://www.cncf.io/blog/2022/10/19/cert-manager-becomes-a-cncf-incubating-project/