Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump sigs.k8s.io/kubebuilder/v3 from 3.11.1 to 3.12.0 in /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1 #3615

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 11, 2023

Bumps sigs.k8s.io/kubebuilder/v3 from 3.11.1 to 3.12.0.

Release notes

Sourced from sigs.k8s.io/kubebuilder/v3's releases.

v3.12.0

changes since v3.11.1

⚠️ Breaking Changes

  • Deprecation of the Declarative Plugin (declarative/v1) (#3395):

The Declarative plugin (declarative/v1) is an implementation derived from the kubebuilder-declarative-pattern project. As the project maintainers possess the most comprehensive knowledge about its changes and Kubebuilder allows the creation of custom plugins using its library, it has been decided that this plugin will be better maintained within the kubebuilder-declarative-pattern project itself, which falls under its domain of responsibility. This decision aims to improve the maintainability of both the plugin and Kubebuilder, ultimately providing an enhanced user experience. To follow up on this work, please refer to the [issue #293](kubernetes-sigs/kubebuilder-declarative-pattern#293).

  • (go/v4): Upgrade k8s 1.27.1 to 1.28.0 and controller-runtime from 0.15.0 to 0.16.0 (#3570)

Controller-runtime has breaking changes see the release notes of the version v0.16.0 . Following the changes required to be introduced in the main.go and in the webhook_suite_test.go:

✨ New Features

  • (kustomize/v2, go/v4) upgrade kustomize version from 5.0.1 to 5.1.1 (#3587)
  • (kustomize/v2, go/v4): upgrade controller-tools from 0.12.0 to 0.13.0 (#3561)
  • (CLI): Standardization of Logs using Library logrus ( replace of fmt.Print ) (#3571)
  • Alpha Command to re-scaffold project (kubebuilder alpha generate) improvements:
    • Add support to deployImage plugin (#3544)
    • Improve logs (#3556)
    • Add support to Grafana Plugin (#3503) (#3509)
    • Add support to Webhooks (#3497)
    • Add support to Create API fields (#3489)
    • Add support to multigroup (#3487)
  • (API): Export config struct to be available for external plugin (#3554)
  • (go/v4): Add .vscode to autogenerated .gitignore files (#3480)

🐛 Bug Fixes

  • (kustomize/v2,go/v4): fix kustomization yaml's webhooks patches file names for multgroup layouts (#3580)
  • (CLI) change deprecated warning to yellow (#3563)
  • (deployimage/v1-beta1): fix scaffold with multigroup and and add optional plugins to multigroup sample to validate changes (#3560)
  • (go/v4): fix makefile target to build images ensuring its single responsibility (#3353)
  • (go/v4): fix grammar in scaffolded makefiles (#3542)
  • (API): Ensure external plugin can scaffold files in new directories (#3519)
  • (CLI): Fix completion in deprecated projects (#3474)
  • (go/v4, deployImage): fix scaffold to allow run the tests directly. Currently, is only possible run via the makefile targets (#3365)
  • (CLI) Fix issue found to re-generate the scaffolds with the new alpha command (#3461)
  • (go/v4,kustomize/v2): Fix kustomize syntax during conversion to patches by (#3456)
  • (go/v4, deployImage): fix scaffold to allow run the tests directly. (#3365)
  • (go/v4): fix makefile target to build images without run the tests (#3353)
  • (go/v4): Start to check ENABLE_WEBHOOKS envvar into main.go to fix issue when webhooks are used (#3578)
  • (kustomize/v2,go/v4): fix kustomization yaml's webhooks patches file names for multgroup layouts (#3580)

🎉 Thanks to all our contributors!

New Contributors

... (truncated)

Commits
  • b48f95c Merge pull request #3588 from kubernetes-sigs/dependabot/github_actions/actio...
  • ba4d579 🌱 bump actions/checkout from 3 to 4
  • 9615151 🌱 chore(deps): bump golang.org/x/text from 0.12.0 to 0.13.0 (#3589)
  • 3b7af7d Merge pull request #3592 from camilamacedo86/gosec-remove
  • 4b51822 :seedleng: remove gosec lint due false claims
  • 919b7a6 🌱 fix lint gosec false complain (#3590)
  • 742ab8b ✨ (kustomize/v2, go/v4) upgrade kustomize version from 5.0.1 to 5.1....
  • acca0c1 Merge pull request #3586 from camilamacedo86/fix-lint-ci
  • 4c20e7e 🌱 fix lint ci issue and update golangci-lint version
  • 8d859ca Merge pull request #3580 from dragon-flyings/fixPatchYaml
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sigs.k8s.io/kubebuilder/v3](https://github.com/kubernetes-sigs/kubebuilder) from 3.11.1 to 3.12.0.
- [Release notes](https://github.com/kubernetes-sigs/kubebuilder/releases)
- [Changelog](https://github.com/kubernetes-sigs/kubebuilder/blob/master/RELEASE.md)
- [Commits](v3.11.1...v3.12.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/kubebuilder/v3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86 camilamacedo86 changed the title Bump sigs.k8s.io/kubebuilder/v3 from 3.11.1 to 3.12.0 in /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1 🌱 Bump sigs.k8s.io/kubebuilder/v3 from 3.11.1 to 3.12.0 in /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1 Sep 12, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-28-0

/test pull-kubebuilder-e2e-k8s-1-26-6

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dependabot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-26-6

1 similar comment
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-26-6

@k8s-ci-robot k8s-ci-robot merged commit 9eeeb45 into master Sep 12, 2023
26 of 27 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1/sigs.k8s.io/kubebuilder/v3-3.12.0 branch September 12, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants