Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Proposal : New Plugin to allow project distribution via helm charts #3632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dashanji
Copy link
Contributor

As titled.

This document is currently in RFC status, and corrections and additions are welcomed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dashanji. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

camilamacedo86

This comment was marked as outdated.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2024
@camilamacedo86 camilamacedo86 force-pushed the add-helm-chart-proposal branch 5 times, most recently from 771e3a5 to 47e59de Compare August 4, 2024 16:59
@camilamacedo86

This comment was marked as outdated.

@scottrigby

This comment was marked as resolved.

Co-Author: Ye Cao <caoye.cao@alibaba-inc.com>
@camilamacedo86
Copy link
Member

camilamacedo86 commented Sep 14, 2024

Hi @scottrigby,

Thank you for your review and comments. I've addressed most of them and realized I was silly in a few details initially. So, good catcher !!! I believe the next step is to start creating the plugin and handle any challenges as they arise. I'll keep the proposal open for further adjustments as we move forward. It either might help others just contribute with. I began to create the scaffold asap I finish other priorities if nobody starts it.

IHMO the main critical points for us on the helm-chart seems to be:

  • handle the webhooks
  • ensure that the proposed Helm Chart layout is the best approach

If you be able to help on that will be great for sure !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.