-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (kustomize/v1,go/v4): Fix yamllint warnings in the scaffolds done under config. #3634
🐛 (kustomize/v1,go/v4): Fix yamllint warnings in the scaffolds done under config. #3634
Conversation
Welcome @MaGaroo! |
Hi @MaGaroo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Makefile
Outdated
@@ -91,7 +91,7 @@ lint-fix: golangci-lint ## Run golangci-lint linter and perform fixes | |||
|
|||
.PHONY: yamllint | |||
yamllint: | |||
@docker run --rm $$(tty -s && echo "-it" || echo) -v $(PWD):/data cytopia/yamllint:latest testdata -d "{extends: relaxed, rules: {line-length: {max: 120}}}" --no-warnings | |||
@docker run --rm $$(tty -s && echo "-it" || echo) -v $(PWD):/data cytopia/yamllint:latest testdata -d "{extends: relaxed, rules: {line-length: {max: 120}}, ignore: /testdata/project-v2/}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kustomize/v1 we should ignore as well
It is deprecated. So that we should no longer change
Could you please revert the changes made into common/kustomize/v1 and rerun make generate to update the samples to push another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I just applied your suggestions.
Does it work for you now?
P.S. If I didn't understand you correctly, just let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🥇
Just a few minor points:
1 - Please revert the changes made under kustomize/v1. This version is deprecated, so we should not make changes to it. You can also ignore it in the makefile target.
2 - After making the above change, please ensure that you squash the commits. We should have one commit per PR to get this merged.
P.S. This is a change that is relevant to the end users. You are fixing an issue in what is provided to them, so the appropriate emoji is 🐛. I hope you don't mind; I updated the title according to the project's conventions for you to check out. However, please feel free to adjust as you see fit. Why does the title matter? We generate the release notes based on the titles of the PRs.
Again, well done. 🎉
/ok-to-test
a0a09e4
to
668741d
Compare
/retest Since the e2e tests are passing in my local machine and 1.28 test has passed in my previous commit, I guess it's flake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
/lgtm
/approved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, MaGaroo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
668741d
to
54535fa
Compare
Oops... Sorry it was my fault. :( |
/retest |
/test pull-kubebuilder-e2e-k8s-1-26-6 |
/lgtm |
Hi!
This PR fixes #3599
Note: There are 5 warnings remaining in
project-v2
testdata. It's root cause isn't the kubebuilder itself, but those yaml files are generated by controller-toolsv0.3.0
. I tried to increase its version, but the code didn't work with the newer versions of controller-tools. So, I just decided to leave those warnings unfixed and addproject-v2
to yamllint'signore
config. Please tell me if you think we can solve this problem in a better way.More Info: Those warnings are as follows. They're generated by running
make manifest
command in the testdata directory.