-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (go/v4) allow golangci-lint version into the Makefile to be customizable #3642
✨ (go/v4) allow golangci-lint version into the Makefile to be customizable #3642
Conversation
Hi @redhatrises. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2231a0b
to
95fc453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🥇
Can you please revert the changes into [pkg/plugins/common/kustomize/v2/scaffolds/webhook.go](https://github.com/kubernetes-sigs/kubebuilder/pull/3642/files#diff-efe5fb949909ea3705dd42c50f0fa08b85316bd316a0820c92c9e6680ef6aec1)
which has no relation with your PR?
See that it needs to pass in the CI to allow us to get it merged.
For we allow it to move forward are required to
a) Rebase your branch with master
b) Run make generate
-> So that all samples will be updated accordinly
c) Run make lint-check
to check the issues (a few of them is possible to solve with make lint-fix automatically)
d) Squash the commits if you have more than one
95fc453
to
9c42eb2
Compare
Signed-off-by: Gabe Alford <redhatrises@gmail.com>
9c42eb2
to
71e2a64
Compare
@camilamacedo86 thanks! I rebased, fixed the linting issue, and re-ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, redhatrises The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Create a variable to make clear the version used in the target.
Also, to allow golangci-lint version to be customizable