Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 stop to generate crd webhooks patches and cainjetions for any CRD/API and projects without webhooks #3647

Merged
merged 1 commit into from
Oct 12, 2023
Merged

🐛 stop to generate crd webhooks patches and cainjetions for any CRD/API and projects without webhooks #3647

merged 1 commit into from
Oct 12, 2023

Commits on Oct 10, 2023

  1. stop to generate crd webhooks patches and cainjetions for any CRD/API… 

    … and projects without webhooks

At present, we scaffold config/crd/patches, kustomizations, and CA injections for every CRD, irrespective of whether webhooks are enabled in the project or not. However, these configurations are only relevant and valid if the project has webhooks.

Consequently, for projects without webhooks, this leads to failures as documented in kubebuilder pull request kubernetes-sigs#3585.

To address this, we are now introducing a test to ensure that projects without enabled webhooks function correctly and as anticipated.

Signed-off-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Co-authored-by: lowang-bh <lhui_wang@163.com>
    @lowang-bh @camilamacedo86
    lowang-bh authored and camilamacedo86 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a4ad443 View commit details
    Browse the repository at this point in the history