-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Upgrade envtest from 0.28.0 to 0.28.3 to ensure that versions used are aligned #3680
Conversation
test/common.sh
Outdated
@@ -50,7 +50,7 @@ if [ -n "$TRACE" ]; then | |||
set -x | |||
fi | |||
|
|||
export KIND_K8S_VERSION="${KIND_K8S_VERSION:-"v1.28.0"}" | |||
export KIND_K8S_VERSION="${KIND_K8S_VERSION:-"v1.28.3"}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the latest kind node image remains 1.28.0
:
https://github.com/kubernetes-sigs/kind/releases .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific good catcher I will revert this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge this one now?
WDYT? Could you LGTM this one?
192682f
to
3ffcdfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
We upgrade the k8s version from 1.28.0 to 1.28.3 but we did not bumped the envtest. More info, check the PR to generate the artifacts: #3679